search

rkazakov / ampify

Convert your HTML to Google AMP (Accelerated Mobile Pages)
MIT License
109 stars 32 forks source link

feature(GoogleAnalytics): Add support for AMP-ANALYTICS #10

Closed blanxii closed 6 years ago

blanxii commented 6 years ago

I'm using this awesome lib in my site but I notice a few errors like this one, the google analytics tracking is not working with the current setup because it's needed to add the amp-analytics lib and also re-write the page-view tracking option.

Notice this is not changing your ga events or custom implementations it's just to add simple tracking inside.

Notice 2 Keep in mind I just move all the test to sub-set of tests I think is more clear instead having a huge file.

rkazakov commented 6 years ago

@blanxii, thanks for your contribution! I will merge PR in the next few days.