search

rkazakov / ampify

Convert your HTML to Google AMP (Accelerated Mobile Pages)
MIT License
109 stars 32 forks source link

sync-request usage #7

Closed tapsboy closed 6 years ago

tapsboy commented 6 years ago

I see that index.js uses sync-request. Is there a specific reason why a sync request is used here instead of an async one?

rkazakov commented 6 years ago

Hi @tapsboy! No specific reason. It should be rewritten to use async version. Please feel free to contribute!

knoxcard commented 6 years ago

Mmmm....Chinese Rice

https://github.com/rkazakov/ampify/pull/11

blanxii commented 6 years ago

Can we close this @rkazakov ?