search

rkcosmos / deepcut

A Thai word tokenization library using Deep Neural Network
MIT License
420 stars 96 forks source link

Zero padding problem: possible (0, 0) padding #28

Closed titipata closed 5 years ago

titipata commented 6 years ago

In model.py, there is a case that padding can be (0, 0) which gives a problem when we want to convert to use in Tensorflow JS:

out = ZeroPadding1D(padding=(0, window-1))(out)

We probably have to modify the following:

if window != 1:
    out = ZeroPadding1D(padding=(0, window-1))(out)
titipata commented 5 years ago

I'll mark this as wontfix. If we come across this issue, we can reopen it.