search

rkcosmos / deepcut

A Thai word tokenization library using Deep Neural Network
MIT License
420 stars 96 forks source link

Remove keras.json from Dockerfile #50

Closed p16i closed 5 years ago

p16i commented 5 years ago

Hi,

It seems keras.json[1] isn't in the repository anymore. However, it's still in Dockerfile and causes docker-build failed.

[1] https://github.com/rkcosmos/deepcut/blob/master/Dockerfile#L39

titipata commented 5 years ago

Hi @kittinan and @chanwit, can someone review this PR?

kittinan commented 5 years ago

Deepcut using default Keras configuration. So we don't have to add the config file to Docker image.

Deepcut Keras config:

{
  "floatx": "float32",
  "epsilon": 1e-07,
  "backend": "tensorflow",
  "image_data_format": "channels_last"
}

Keras default config: https://keras.io/backend/#switching-from-one-backend-to-another

kittinan commented 5 years ago

This pull request will fix Issue #36

chanwit commented 5 years ago

LGTM

titipata commented 5 years ago

Seems like I can merge the PR then!

chanwit commented 5 years ago

In case of having a custom Keras file, one could bind a local Keras file into the container like:

docker run -v $PWD/keras.json:/root/.keras/keras.json deepcut
p16i commented 5 years ago

Thanks!

Actually, it would be more convenient if we have a built DeepCut image hosted on hub.docker.com.

chanwit commented 5 years ago

Please someone setup the deepcut organization there on Docker hub, and grant me an access. I'll help maintain the images.

Basically, the image name would be something like deepcut/deepcut:latest