search

rkd77 / elinks

Fork of elinks
Other
349 stars 38 forks source link

[ win32 ] on mingw win32 there is undefined reference to inet_aton #164

Closed mtatton closed 2 years ago

mtatton commented 2 years ago

Hello rkd77,

on mingw win32 I successfully compiled version of elinks and ran on windows 2000 here: https://github.com/rkd77/elinks/pull/163

However on small change had to be done in src/network/ssl/socket.c I discarded the inet_aton usage. But it doesn't seems to me so good to make it as a change for commit.

Any idea how to solve this?

Thank You for any response.

287 / cert_host_addr, url_host_in, and url_host_in6 are all in 288 network byte order. */ 289 switch (ASN1_STRING_length(cert_host_asn1)) { 290 case 4: 291 #ifndef HAVE_INET_PTON 292 #ifndef WIN32 293 return inet_aton(uri_host, &uri_host_in) != 0 294 && memcmp(cert_host_addr, &uri_host_in.s_addr, 4) == 0; 295 #else 296 return 0; 297 #endif 298 #else 299 300 return inet_pton(AF_INET, uri_host, &uri_host_in) != 0 301 && memcmp(cert_host_addr, &uri_host_in.s_addr, 4) == 0; 302 #endif 303

rkd77 commented 2 years ago

Try this commit f6af4d353810439d015be924176e55ab2cc86ee9 If did not help, fix configure.ac or meson.build.

mtatton commented 2 years ago

Great, this is compiling and working perfectly. I'll just reopen the save issue I closed previously. There is still problem with saving configuration. I tried the win32 version on win2k and the config does not save and elinks has to be reconfigured on each start. I'll reopen it and investigate it.

Thank You very much.

mtatton commented 2 years ago

Closing this. Thank You very much.