rkd77 / elinks

Fork of elinks
Other
349 stars 38 forks source link

Open a bookmark from the bookmark manager in a new tab. #237

Closed ZaxonXP closed 1 year ago

ZaxonXP commented 1 year ago

Currently in order to open a bookmark from bookmark manager in a new tab I need to: 1) Open a new tab (key t). 2) Close the "Go to URL" screen (key Esc) 3) Open the bookmark manager (key s) 4) Select and open the bookmark

Is there a way to open the bookmark in a new tab directly from the bookmark manager?

Kind regards, Piotr

rkd77 commented 1 year ago

AFAIK there is no such option yet. Many dialogs with "Go to" share the same code. You can test this change: `diff --git a/src/bfu/hierbox.c b/src/bfu/hierbox.c index 8debbe90..99c20190 100644 --- a/src/bfu/hierbox.c +++ b/src/bfu/hierbox.c @@ -522,7 +522,8 @@ push_hierbox_goto_button(struct dialog_data dlg_data, struct uri uri = box->ops->get_uri(item);

            if (uri) {

` Numeric values in open_uri_in_new_tab can be 0 or 1, so you have 4 choices. Check which ones are best here. Bookmarks manager has already 10 buttons, so adding one more is not a good idea. If you test open_uri_in_new_tab, I'll consider bool option to choose between goto_uri and new tab in "Go to" hierbox.

ZaxonXP commented 1 year ago

I tried with the version you provided and it works for me well. Will you merge this change to the main branch or each version I will have to change the code before the compilation? Or maybe you make this configurable in the elinks settings?

rkd77 commented 1 year ago

Value for document.browse.links.hierbox_goto, either 1 or 2 if you want tabs.

ZaxonXP commented 1 year ago

Is this option also available in the Option Manager or only in the config file?

ZaxonXP commented 1 year ago

ok. I found it. It is quite logical from the variable name. :) Thanks again!