search

rkennedy / setting-watchdog

Reset OS settings when they change
The Unlicense
0 stars 0 forks source link

Prefer UTF-8 where possible #27

Closed rkennedy closed 4 years ago

rkennedy commented 4 years ago

This change introduces Boost.Nowide to use UTF-8 in place of Windows Unicode wherever possible. Some API functions become a little more complicated to call, but with only one kind of string to print anymore, the stream I/O (including logging) become more consistent.

This resolves #19.

rkennedy commented 4 years ago

The CI builds associated with this PR are puzzling. The key for the vcpkg cache is supposed to include the contents of vcpkg-response.txt, and yet, when commit a222623 explicitly changed that file, the cache key didn't change. The run-vcpkg step found a previous cache, restored it, and then added the new boost-nowide package.

It's nice that that happened, since it saved about 15 minutes, but it's not at all clear why it worked that way.