search

rkern / line_profiler

(OLD REPO) Line-by-line profiling for Python - Current repo ->
https://github.com/pyutils/line_profiler
Other
3.6k stars 256 forks source link

TST: Update test matrix #147

Open pllim opened 5 years ago

pllim commented 5 years ago

It is chronically failing and Python 3.3 is rather old by now.

jakirkham commented 5 years ago

I think it is also unsupported. Is someone able to review this PR?

cclauss commented 5 years ago

3.4 is EOL now too.

cclauss commented 5 years ago

Also see #162

pllim commented 5 years ago

Hah, @cclauss , looks like we are duplicating each other. I just updated this PR too. Anyway, I'll let the maintainers decide. I was just trying to help on the side and not really involved with this project.

cclauss commented 5 years ago

Same. It was a dependency on a project so I jumped in to see what the real story was. If you want to cherrypick the 3.7 and 3.8-dev stuff out of #162 and put them into this PR then I will gladly close #162.

pllim commented 5 years ago

@cclauss , I think in a way I already did, except that I am not allowing 3.7 to fail.

pllim commented 5 years ago

p.s. Yikes, it just failed, so maybe I'll have to.

cclauss commented 5 years ago

The problem is that very few maintainers pay a lot of attention or merge PRs that have failing tests. ;-)

cclauss commented 5 years ago

153 or similar is required to be compatible with Python 3.7.

pllim commented 5 years ago

p.s. As far as your dependency tree is concerned, given that this PR has been open for 4 months, you might want to be in contact with the maintainers or maybe have someone from your company to volunteer to co-maintain this. Just a thought.