rkern / line_profiler

(OLD REPO) Line-by-line profiling for Python - Current repo ->
https://github.com/pyutils/line_profiler
Other
3.6k stars 256 forks source link

Compile error on OS X #151

Open timkofu opened 5 years ago

timkofu commented 5 years ago

pip install line_profiler does not compile on OS X.

Here is the log http://sprunge.us/Uxh1G8

hylarucoder commented 5 years ago

same +1

hylarucoder commented 5 years ago

@timkofu

I tried this and solved

pip install Cython git+https://github.com/rkern/line_profiler.git

timkofu commented 5 years ago

@twocucao worked for me too. So the fix is in master https://github.com/rkern/line_profiler/commit/df8dfc88049effeac5fb77830bc9456052ea5c33

Will leave the issue open in case @caethan wants to close it after making a release with the bugfix.

hylarucoder commented 5 years ago

maybe its a Cython Problem? @timkofu

timkofu commented 5 years ago

@twocucao I'm basing my conclusion on; in both cases the cython version is 0.29.6, but the line_profiler on pypi is 2.1.2, and the one installed directly from the github repo is actually older at 2.1.1 So being that line_profiler has the new version with the error and the older one without, that's where the problem is.

hylarucoder commented 5 years ago

@timkofu

I guess maybe there is something different from installation from githuburl or pypi. because

pip3 install line_profiler==2.1.1

not working too

Actually, I use Poetry to build my package, when i install from github url, it's fine. But When I install my built package which would install line_profiler again , the error comes again.

And I decide not to build line_profiler into mypackage.