search

rkern / line_profiler

(OLD REPO) Line-by-line profiling for Python - Current repo ->
https://github.com/pyutils/line_profiler
Other
3.6k stars 254 forks source link

line-profiler fails to install on Python 2 #89

Open thanatos opened 7 years ago

thanatos commented 7 years ago

According to setup.py, line-profiler supports Python 2. However, it also lists a requirement on IPython>=0.13, which causes pip to attempt to install IPython==6.0.0, which cannot install on Python 2, as they (IPython) have dropped support for legacy versions of Python.

Can I suggest two requirements, one on IPython>=0.13, with an env_marker for 3, and one for IPython>=0.13,<6 with an env marker for 2?

(I'll see if I can send a patch)

pllim commented 5 years ago

Given that Python 2 is at the end of life by now, I propose instead of drop Python 2 support altogether. :grimacing: