search

rkgibson2 / data-driven-dota

Dota 2 visualizations, for CS 171 final project
6 stars 2 forks source link

to fix #11

Closed huihuifan closed 10 years ago

huihuifan commented 10 years ago
  1. aegis doesn't have a cost
  2. hero graph not appearing
  3. fancy tooltips?
  4. sliding on the bar graph
  5. images on the bar graph
huihuifan commented 10 years ago

fixed 1 and 2.

Ideas for what to do with recipes? @BenjyLevin @rkgibson2

huihuifan commented 10 years ago

did #3 and #5.

sliding seems difficult.

huihuifan commented 10 years ago

need scale on item percent bar chart @BenjyLevin how did you do this for your bonus problem?

rkgibson2 commented 10 years ago

New Thing: @huihuifan Hero sunburst transition.

BenjyLevin commented 10 years ago

New thing @rkgibson2

I don't think we want to throw errors during the linear search in the d2 library. For instance, if I want hero info with ID 110, the linear search will throw error at ID 105 since that hero doesnt exist, and wont continue searching through the array.

I commented out the throw error and just returned 0. This may be an issue with some of the other search functions

rkgibson2 commented 10 years ago

@BenjyLevin What do you mean? The search iterates over all the heroes and checks whether that id is equal to the id we're looking up. It doesn't care what order the heroes are in in heroes.json. If it reaches the end, it knows it hasn't found anything and the hero doesn't exist in the json file

BenjyLevin commented 10 years ago

The problem is that it indexes into "heroData[i].id" but for example, heroData[25].id does not exist, so it throws an exception, instead of carrying on the linear search.

BenjyLevin commented 10 years ago

I suppose we can have a quick check like: if(heroData[i].id)..

huihuifan commented 10 years ago

closed. new updated to fix file anyway