Closed huihuifan closed 10 years ago
Set default to me
4 finished earlier.
2 and 3 now done.
Working on 1.
we need to filter by lobby type as well
https://github.com/kronusme/dota2-api/blob/master/data/lobbies.json
Kwl I'll add this to the filter
On Apr 15, 2014, at 7:59 PM, Robbie Gibson notifications@github.com wrote:
we need to filter by lobby type as well
https://github.com/kronusme/dota2-api/blob/master/data/lobbies.json
— Reply to this email directly or view it on GitHub.
thanks! :) filter by match type is working super well
On Tue, Apr 15, 2014 at 8:39 PM, BenjyLevin notifications@github.comwrote:
Kwl I'll add this to the filter
On Apr 15, 2014, at 7:59 PM, Robbie Gibson notifications@github.com wrote:
we need to filter by lobby type as well
https://github.com/kronusme/dota2-api/blob/master/data/lobbies.json
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/rkgibson2/Dota-2-visualizations/issues/30#issuecomment-40551361 .
Is it possible to filter out items from the data set that we'll never use on load (like diretide and wraith-night games, etc.)
I also fixed the data, enter, exit setup for the timeline transition
@rkgibson2 yer I'll run a filter on load
wrote underlying code for 1 - need to discuss how we want to display these things
filtering by lobby type (3) also added to the graph but also need to discuss where this will be placed
closing this - all the above implemented - opening new issue for the issues surrounding any of these implementations.
maybe we shouldn't default to me, because two of the graphs basically don't show anything? thoughts?