search

rkgibson2 / data-driven-dota

Dota 2 visualizations, for CS 171 final project
6 stars 2 forks source link

reformatting #40

Closed huihuifan closed 10 years ago

huihuifan commented 10 years ago

Do you think it makes sense to have the game mode filter inside the hero filter?

also, is it possible to move the timeline upwards so it is inline with the filters?

@BenjyLevin @rkgibson2

BenjyLevin commented 10 years ago

I was speaking to Robbie earlier and we felt that both ways make sense. I feel that having it separate is cleaner (keeping the filter button only for heroes) and more useful since you can easily make changes to the data shown if you see outliers. But if you really feel that having it inside the hero filter is better, we can switch to that. I think all these design decisions will become clearer once everything is brought together on one page and our layout represents more of final layout than it does now :)

On Apr 15, 2014, at 7:42 PM, Huihui Fan notifications@Github.com wrote:

Do you think it makes sense to have the game mode filter inside the hero filter?

also, is it possible to move the timeline upwards so it is inline with the filters?

@BenjyLevin @rkgibson2

— Reply to this email directly or view it on GitHub.

huihuifan commented 10 years ago

ok! let's wait until we see the final layout :)

BenjyLevin commented 10 years ago

@huihuifan

ok I have just pushed a biiiiig update: the filtering code has been completely reworked to include a new "super function" called tripleFilterUpdate() which applies all the old filtering methods as well as the new lobby filter in one pass of the data set - it is much more efficient and doesn't rely on multiple js file function calls. Aesthetically, this looks awful lol, but I am working on a way to either style this better, put it in its own modal, or put it inside the hero filter modal - update to follow soon!

BenjyLevin commented 10 years ago

reformatted filters to be in their own modal.