search

rkgibson2 / data-driven-dota

Dota 2 visualizations, for CS 171 final project
6 stars 2 forks source link

timeline click #41

Closed huihuifan closed 10 years ago

huihuifan commented 10 years ago

so if a user clicks on the timeline without brushing, we need to figure out how to not read the event, because it consoles a lot of errors and all of the graphs blank?

@BenjyLevin

BenjyLevin commented 10 years ago

This is the same problem on the xpm and gpm graphs and I'm not entirely sure how to fix it but will look into it.

On Apr 15, 2014, at 8:34 PM, Huihui Fan notifications@github.com wrote:

so if a user clicks on the timeline without brushing, we need to figure out how to not read the event, because it consoles a lot of errors and all of the graphs blank?

@BenjyLevin

— Reply to this email directly or view it on GitHub.

huihuifan commented 10 years ago

But on the gpm/xpm graphs it doesn't break the rest of the stuff? I will look into it too

On Tue, Apr 15, 2014 at 8:38 PM, BenjyLevin notifications@github.comwrote:

This is the same problem on the xpm and gpm graphs and I'm not entirely sure how to fix it but will look into it.

On Apr 15, 2014, at 8:34 PM, Huihui Fan notifications@github.com wrote:

so if a user clicks on the timeline without brushing, we need to figure out how to not read the event, because it consoles a lot of errors and all of the graphs blank?

@BenjyLevin

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/rkgibson2/Dota-2-visualizations/issues/41#issuecomment-40551314 .

huihuifan commented 10 years ago

fixed by @rkgibson2