rkgibson2 / data-driven-dota

Dota 2 visualizations, for CS 171 final project
6 stars 2 forks source link

introJS #61

Closed BenjyLevin closed 10 years ago

BenjyLevin commented 10 years ago

So I started implementing the introJS but there is a known issue for using introJS with fixed position html objects: http://stackoverflow.com/questions/15576220/how-introjs-achieve-the-highlighted-areas http://updates.html5rocks.com/2012/09/Stacking-Changes-Coming-to-position-fixed-elements

And our filtering bar is fixed, which results in the introJS layering over the objects and we cant see what is underneath them.... I'm not sure if there is a work around unless we change the filtering bar to non fixed. @rkgibson2 thoughts? introjs problem

rkgibson2 commented 10 years ago

I'm not sure what we can do. If the timeline isn't fixed, then it won't stay at the top. I guess we could move it back to normally positioned, but then we lose that "header" look, and I think that is really important.

huihuifan commented 10 years ago

Checking it out now

BenjyLevin commented 10 years ago

Do you think we can normally position the timeline and then fix position it on exit of the introJS tour? I know that there is a way to call a function after an introJS tour is completed/exited.

huihuifan commented 10 years ago

Ok I think the bigger problem is that a lot of the Intro JS text/box is cut off

rkgibson2 commented 10 years ago

You could try that. It may work.

BenjyLevin commented 10 years ago

I think that may have to do with the fixed positioning too

huihuifan commented 10 years ago

I am also not sure if walking the user through each filter is useful if the text is "Click here to open up the hero filter" since the button already says "Filter by Heroes." Maybe we should have a Intro JS that selects the entire header and describes it briefly, rather than walking the user individually through each button?

Not sure.

BenjyLevin commented 10 years ago

Although its weird that the intro.js numbers are not in the middle of their circles...

huihuifan commented 10 years ago

Yeah I noticed that too, not sure what is going on

BenjyLevin commented 10 years ago

Yer I agree, I was just testing the functionality out