bugs

[huihuifan]

november on the timeline is cut off @BenjyLevin a few of the numbers from intro js are cut off @BenjyLevin - fixed crazy spacing on the items bar graph @self - fixed filter underneath header @rkgibson2 - fixed

[huihuifan]

double line on xpm x axis @self - fixed

[huihuifan]

100% cutoff for winrate color legend on bubble graph @rkgibson2 - fixed

[huihuifan]

multiple things on timeline turned aquamarine @rkgibson2 - fixed

[huihuifan]

double thick y axis top line on items graph @self - fixed

[huihuifan]

intro js selection on filtering bar looks kind of weird? @BenjyLevin - not issue

[huihuifan]

intro js on records not symmetric spacing from top and bottom @BenjyLevin - fixed

[huihuifan]

change graph descriptions to "user" not "you" @self- fixed

[BenjyLevin]

@huihuifan removed the numbers as there is no way to prevent them being cut off by page boundary.

also spaced symmetrically.

@huihuifan not sure where else to highlight for this?

[huihuifan]

@BenjyLevin fair enough on the header highlighting. I think it looks good. Missing numbers is ok- I think cutoff numbers is worse.

[BenjyLevin]

@rkgibson2 pulling up the end game screen from clicking on a dot in the GPM graph, and then trying to view the skill build of a hero in the game, produces an error. (strange, lol)

Also if skill build is open, and then the user clicks on another dot, the skill build doesn't close but just remains open over the new different match selection.

[rkgibson2]

Ok, i solved the second issue and closed the screen.

For the first one, i think that it's not actually the GPM graph clicking. It looks like any game before February 1, 2013 doesn't have ability upgrade data, so any of those games produce errors. Any suggestions on how to deal with this (in a UI way, like should we alert that these games don't have ability data?, say that in the popup?)

[BenjyLevin]

Oh wow nice catch! Yer I think just a "Sorry, no ability upgrade data available" in the box would be the most elegant way to handle it.

On Apr 29, 2014, at 7:55 PM, Robbie Gibson notifications@github.com wrote:

Ok, i solved the second issue and closed the screen.

For the first one, i think that it's not actually the GPM graph clicking. It looks like any game before February 1, 2013 doesn't have ability upgrade data, so any of those games produce errors. Any suggestions on how to deal with this (in a UI way, like should we alert that these games don't have ability data?, say that in the popup?)

— Reply to this email directly or view it on GitHub.

[rkgibson2]

@BenjyLevin The records code errors on an empty data set.

[BenjyLevin]

@rkgibson2 fixed the records on empty dataset. Do we also want to fix the NaN% on an empty data set? @huihuifan

[BenjyLevin]

Also if you brush the XPM/GPM graphs on an empty data set, they also error

[huihuifan]

I will fix these two now

On Apr 30, 2014, at 3:04 PM, Benjy Levin notifications@github.com wrote:

Also if you brush the XPM/GPM graphs on an empty data set, they also error

— Reply to this email directly or view it on GitHub.

[huihuifan]

@BenjyLevin I get this error:

Uncaught TypeError: Cannot read property 'style' of null introjs557

[huihuifan]

And this error when I swipe a region with no games:

Uncaught TypeError: Cannot read property 'hero_id' of undefined records.js 88

[BenjyLevin]

Ok. I'm coming to your room now and you can show me. That error wasn't happening on my side.

On Apr 30, 2014, at 5:58 PM, Huihui Fan notifications@github.com wrote:

And this error when I swipe a region with no games:

Uncaught TypeError: Cannot read property 'hero_id' of undefined records.js 88

— Reply to this email directly or view it on GitHub.

[huihuifan]

no nevermind! I forgot to pull!! Sorry sorry :(

[huihuifan]

fixed all of these, benjy says november thing is a d3 thing and very hard to mess with since it's auto placement