search

rkgibson2 / data-driven-dota

Dota 2 visualizations, for CS 171 final project
6 stars 2 forks source link

Video Feedback #64

Closed BenjyLevin closed 10 years ago

BenjyLevin commented 10 years ago

@huihuifan

I really like it! The generated datasets look great - especially the user bubble with Robbie! I also like the cinematics. I just have a few comments to make:

1) Occasionally it cuts really quickly to some other selection without the filtering actually occurring on screen - like at the windranger part. This is a little disjointed. Is there anyway around this? Either through making this filtering selection or starting with this prefiltered, or screen to black for less than a second then continue..? fixed, cut the clips of filtering out

2) I guess a similar point with the snippets of in-game cinematics - a fade-in maybe? Or some sort of transition... I guess try a few things and see if something flows better. fixed. did fade-in

3) I'm not too sure if I like the cute pictures of "Robbie" and "Angela" - they kind of randomly just appear lol. Also seems a little visually disjointed although they do match up with the audio nicely! Thoughts? Maybe remove? Or Transitions? Same size backgrounds? Dota-theme integration? made white background with transitions

4) I think we need our names in the beginning after the title screen or at the end in the form of credits, to say who did the project. fixed, added our logo with credits

5) In the same vein, and hopefully not to sound too vain, currently I only mention both of your names and not my own, and we have no credits. Any chance I can start by saying: "Hi my name is Benjy, and today I would like to introduce our project: Data Driven Dota. Meet Robbie....Meet Angela...."? will fix when receive audio file

But otherwise I think it looks great and the project turned out amazing :D awesome work everyone!

huihuifan commented 10 years ago

On the credits at the very end, maybe put the last word on the first line on the second line? I watched it this morning so I don't remember the exact words, but I think you credit 3 different entities, and thought it would look better if each entity was on a separate line fixed

rkgibson2 commented 10 years ago

I think you should remove the unfilter from the windrunner section. I don't mind cutting to the filter, because it just appears, and if you aren't watching, you probably won't notice, but the unfilter is jarring.

ok

I like the pictures of "Robbie" and "Angela," although maybe try to make the whole background white? Instead of having the black as well. ok

There may be space at the beginning to add our names? Do we know how hard the 2 minute limit is? ok

Also, the drawing animation on the logo at the end doesn't end before the transition takes it away. Can it be sped up?

ok

huihuifan commented 10 years ago

ok. will make changes wed

will add credits. will look like this:

CS171. Angela Fan, Robbie Gibson, Benjy Levin. Narrated by: Benjy Levin

End credits will include that i made the logo.

benjy do you still want to record you intro-ing yourself?

BenjyLevin commented 10 years ago

I think let's have the "CS171. Angela Fan, Robbie Gibson, Benjy Levin." at the beginning when I say the "Hi my name is Benjy, and today I would like to introduce you to our CS171 project: Data Driven Dota" and on the mention of Data Driven Dota we can fade into the intro animation? Maybe the "CS171. Angela Fan, Robbie Gibson, Benjy Levin." should be bold black text over our splash screen? I'll send you the recording by this evening!

added! The background of the splash I left black.

BenjyLevin commented 10 years ago

@huihuifan maybe soft musical theme in the background while the talking is happening? https://www.youtube.com/watch?v=muq4U2crdgM

is there any way to get this as an mp3 file? @rkgibson2 @BenjyLevin

huihuifan commented 10 years ago

Sounds good to all of this! I will experiment! Thanks for all of the helpful feedback guys!!

Benjy- I like you saying your name better too!!

On Apr 29, 2014, at 10:17 AM, Benjy Levin notifications@github.com wrote:

I think let's have the "CS171. Angela Fan, Robbie Gibson, Benjy Levin." at the beginning when I say the "Hi my name is Benjy, and today I would like to introduce you to our CS171 project: Data Driven Dota" and on the mention of Data Driven Dota we can fade into the intro animation? Maybe the "CS171. Angela Fan, Robbie Gibson, Benjy Levin." should be bold black text over our splash screen? I'll send you the recording by this evening!

— Reply to this email directly or view it on GitHub.

huihuifan commented 10 years ago

Benjy- what do you think about using the middle portion of the theme? The beginning has those loud spikes- I am scared they will interrupt your audio, but if I turn it down you won't be able to hear the rest of the song.

Thoughts? I can check out other audio tracks. I think the idea of sound in the background is a great idea though- it will make our video seem more professional :)

On Tue, Apr 29, 2014 at 10:45 AM, Angela Fan anarfish@gmail.com wrote:

Sounds good to all of this! I will experiment! Thanks for all of the helpful feedback guys!!

Benjy- I like you saying your name better too!!

On Apr 29, 2014, at 10:17 AM, Benjy Levin notifications@github.com wrote:

I think let's have the "CS171. Angela Fan, Robbie Gibson, Benjy Levin." at the beginning when I say the "Hi my name is Benjy, and today I would like to introduce you to our CS171 project: Data Driven Dota" and on the mention of Data Driven Dota we can fade into the intro animation? Maybe the "CS171. Angela Fan, Robbie Gibson, Benjy Levin." should be bold black text over our splash screen? I'll send you the recording by this evening!

— Reply to this email directly or view it on GitHubhttps://github.com/rkgibson2/Dota-2-visualizations/issues/64#issuecomment-41681058 .

BenjyLevin commented 10 years ago

Yer I definitely think the middle portion would be best! And it should be more or less the right length for the video!

huihuifan commented 10 years ago

Got it. I just finished a final and have a final project prez tomorrow, but will try and make edits ASAP

On Apr 29, 2014, at 11:59 AM, Benjy Levin notifications@github.com wrote:

Yer I definitely think the middle portion would be best! And it should be more or less the right length for the video!

— Reply to this email directly or view it on GitHub.

BenjyLevin commented 10 years ago

awesome. goodluck with your presentation and hope the final was good! I'll send you the intro audio file in a bit!

huihuifan commented 10 years ago

Guys we're about ten seconds over time...thoughts?

BenjyLevin commented 10 years ago

I think that's fine... as long as its under 2:30 it shouldn't be an issue

huihuifan commented 10 years ago

ok. please send along audio file. thanks.

huihuifan commented 10 years ago

ok i think i fixed everything. i haven't added the hero pick audio yet though- i haven't figured out how to get it to a mp3 file

we are a little over time but i think we will be ok

huihuifan commented 10 years ago

new video: https://www.youtube.com/watch?v=dqEPDAj5nlc&feature=youtu.be