Intro Js for header - Githubissues

rkgibson2 / data-driven-dota

Dota 2 visualizations, for CS 171 final project

6 stars 2 forks source link

Intro Js for header #72

Closed rkgibson2 closed 10 years ago

rkgibson2 commented 10 years ago

On the step with timeline instructions, it selects the entire header. Is that intended? Also, on that step, the selector extends outside the header, and a little horizontal scroll bar appears on the bottom.

BenjyLevin commented 10 years ago

Entire header is intended since there is no other location to really select for the timeline. Didn't notice the scroll bar before, what should we do about it?

rkgibson2 commented 10 years ago

what about the timeline div / svg

BenjyLevin commented 10 years ago

Can't do the svg because of the weird fixed/absolute positioning stuff, and the timeline div doesn't nicely encase the timeline itself.

rkgibson2 commented 10 years ago

I fixed the positioning issue. Now it does enclose the timeline.