rkhmelyuk / multirun

IntellijIDEA plugin to group and run multiple Run Configurations in a single click
http://plugins.jetbrains.com/plugin/7248
Apache License 2.0
93 stars 27 forks source link

Included run configurations are referenced by display name, which is unreliable #103

Open jansorg opened 1 month ago

jansorg commented 1 month ago

I'm the author of BashSupport Pro and I've received this support request, which involves Multirun: https://github.com/BashSupport-Pro/bashsupport-pro/issues/170

tl;dr; getId() should be used instead of getDisplayName(). If you accept pull requests and would publish a new version, I'd be willing to submit a pull request to make this change.

BashSupport Pro offers a run configuration, which is compatible with JetBrains Shell's run configuration format to allow to continue using the Shell configurations after switching to BashSupport Pro. The compatibility run configuration doesn't work with the Multirun plugin, though.

The problem is that Multirun references the included run configurations by getDisplayName() and not by getId(). Using the display name is unreliable, because

getId() is unique and should be used instead to reliably reference a run configuration. For compatibility with previously created configuration, I'd recommend to fall back to getDisplayName() if there's no match for getId().

As mentioned above, I'm willing to make this change if you'd publish this in the near future.

Source code: https://github.com/rkhmelyuk/multirun/blob/c58bc0f64f104043577fdf8c3ef0b0d673183da7/src/main/java/com/khmelyuk/multirun/MultirunRunConfiguration.java#L48-L50

jansorg commented 1 month ago

@rkhmelyuk Do you have an update on this, perhaps?