ORF1a/b duplicates - Githubissues

rki-mf1 / sc2-mutation-frequency-calculator

Python tool to calculate characteristic and signature mutations based on mutation profiles for a certain timeframe.

0 stars 0 forks source link

ORF1a/b duplicates #4

Closed hoelzer closed 1 year ago

hoelzer commented 1 year ago

Hey,

ORF1ab is a bit complicated due to a Frameshift region that results in two products: ORF1a and ORF1b.

Covsonar outputs duplicate entries and thus they also appear in your matrix, e.g.:

Screenshot 2023-06-13 at 18 02 54

Here, the ones that you marked yellow.

I would say we can do the following: we merge all duplicate positions into "ORF1ab" entries and the remaining unique ones stay as "ORF1a" and "ORF1b", respectively.

ashkan98 commented 1 year ago

done

hoelzer commented 1 year ago

👍 then you can close the issue

Btw, to practice a bit GitHub skills you can also try the following next time when you solve an issue:

Make a branch
Make code changes in the branch, commit changes to the branch
- in the commit mssg, you can reference the issue Id, e.g. here #4.
generate a pull request (e.g. via the GitHub browser GUI)
merge the pull request and delete the branch

Not sure if you anyway know that procedure. It's more important when working with multiple people on code. But anyway good to know and internalize