search

rkillick / changepoint

A place for the development version of the changepoint package on CRAN.
127 stars 33 forks source link

Pruning bug and TRAVIS CI fix #33

Closed AndrewC1998 closed 5 years ago

AndrewC1998 commented 5 years ago

These changes should fix the issues Alex's earlier work was causing TRAVIS CI to fail. Once the initial corrections were made to type not being handed over in cpt.class and also the index error in the c file, the same plots could be generated. However, there is an error within the vdiffr that seems to force the plots to not be considered the same. We will re-add the diffr functionality to the tests once this issue has been resolved in the package. The issue can be found at: https://github.com/r-lib/vdiffr/issues

AC

codecov[bot] commented 5 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.13%. The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #33      +/-   ##
=========================================
+ Coverage   51.77%   51.9%   +0.13%     
=========================================
  Files          20      20              
  Lines        2117    2129      +12     
=========================================
+ Hits         1096    1105       +9     
- Misses       1021    1024       +3
Impacted Files Coverage Δ
R/cpt.class.R 33.73% <100%> (-0.12%) :arrow_down:
src/PELT_one_func_minseglen.c 85.1% <88.88%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04d1f85...f75b478. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.13%. The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #33      +/-   ##
=========================================
+ Coverage   51.77%   51.9%   +0.13%     
=========================================
  Files          20      20              
  Lines        2117    2129      +12     
=========================================
+ Hits         1096    1105       +9     
- Misses       1021    1024       +3
Impacted Files Coverage Δ
R/cpt.class.R 33.73% <100%> (-0.12%) :arrow_down:
src/PELT_one_func_minseglen.c 85.1% <88.88%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04d1f85...f75b478. Read the comment docs.