rkitover / vimpager

Use Vim as PAGER
http://www.vim.org/scripts/script.php?script_id=1723
Other
767 stars 72 forks source link

vimpager breaks with vim 9 #267

Open mattmartini opened 1 year ago

mattmartini commented 1 year ago

After upgrading to vim 9 (vim 9.0.350, mac os big sur 11.7) vimpager does not display any text.

Running vimpager on a text file seems to open the file (as shown with :ls), yet no text is shown in the buffer.

Any movement commands give a "--No lines in buffer--" error.

I have confirmed this behavior on a few different computers. This is what I am seeing, lorem test file (the blank one is vim9, the one showing text is vim8):

vim8 vim9

rkitover commented 1 year ago

Thanks, looking at this now.

rkitover commented 1 year ago

I cannot reproduce this with macOS High Sierra 10.13.6.

Using vim 9.0 from Homebrew.

I cannot reproduce this on a system with Monterey and the Apple vim 9.0 build either.

Please upload a tarball somewhere containing your ~/.vimrc and ~/.vim and any other relevant files.

Also, can you try using the vim from Homebrew? Any difference in behavior?

mattmartini commented 1 year ago

I am using vim and vimpager from homebrew.   I will send my rc files later, I am not home nowSent from my iPhoneOn Oct 2, 2022, at 7:00 AM, Rafael Kitover @.***> wrote: I cannot reproduce this with macOS High Sierra 10.13.6. Using vim 9.0 from Homebrew. I cannot reproduce this on a system with Monterey and the Apple vim 9.0 build either. Please upload a tarball somewhere containing your ~/.vimrc and ~/.vim and any other relevant files. Also, can you try using the vim from Homebrew? Any difference in behavior?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

rkitover commented 1 year ago

I see, the problem is that you're using the vimpager formula from Homebrew and not the Git version of vimpager.

It's my fault that I haven't yet made a release in almost 10 years, I'll try to do that later today.

mattmartini commented 1 year ago

Great. Looking forward to the upgrade (where it actually works again ;)

rkitover commented 1 year ago

You can try the git version in the meantime, you just clone it and put the directory in your path.

mattmartini commented 1 year ago

The git version works fine. Looking forward to the homebrew version so it is easy to deploy to many machines. Thanks!!

algogrit commented 1 year ago

I see, the problem is that you're using the vimpager formula from Homebrew and not the Git version of vimpager.

It's my fault that I haven't yet made a release in almost 10 years, I'll try to do that later today.

Is there anyway I can contribute here?

rnhurt commented 1 year ago

I'm seeing the same behaviour after upgrading to macOS Ventura (13.0), which is running vim v9. I'm also using vimpager from homebrew.

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Sep 30 2022 03:10:57)

emaba commented 1 year ago

Please update the brew version since the git version is working well. Thank you.

simono commented 1 year ago

While the new release of vimpager is in the works, you can install vimpager from git using brew:

brew install --HEAD vimpager

That should make vimpager functional again 😄

emaba commented 1 year ago

While the new release of vimpager is in the works, you can install vimpager from git using brew:

brew install --HEAD vimpager

That should make vimpager functional again 😄

Thank you!!

ryandesign commented 4 months ago

I haven't yet made a release in almost 10 years, I'll try to do that later today.

You can try the git version in the meantime

What is the status of the new release? Users and package management systems want to update to stable versions of software, not random commits.

ryofurue commented 5 days ago

I was wondering whether I should create a new thread . . . Anyway, I did

   brew install --HEAD vimpager

but, vimpager doesn't do syntax highlighting. My ~/.vimrc says syntax on and vim itself does syntax highlighting.

Does vimpager do syntax highlighting now?

I'm on macOS 14.5.

mattmartini commented 5 days ago

You need to create a ~/.vimpagerrc (or ~/.vim/vimpagerrc) file. It should be a subset of your .vimrc that turns on your syntax highlighting.

filetype on
filetype plugin on
filetype indent on
syntax on
""" VimPager settings and overrides
" let vimpager_use_gvim = 1
let vimpager_passthrough = 0
let vimpager_disable_x11 = 1
" let vimpager_disable_ansiesc = 1
let vimpager_scrolloff = 3
...

This is part of my .vimpagerrc, it should be enough to point you in the right direction.

ryofurue commented 3 days ago

@mattmartini Thanks for the help! But, somehow the problem has cured itself, perhaps because I restarted my terminal program (iTerm2)? I still don't have ~/.vimpagerrc. Puzzling.