rkoeninger / ShenScript

Shen for JavaScript
BSD 3-Clause "New" or "Revised" License
57 stars 4 forks source link

Shen 22.0 Upgrade #14

Closed rkoeninger closed 5 years ago

rkoeninger commented 5 years ago
rkoeninger commented 5 years ago

@tizoc Example feature list is [shen-script js node windows]. Is that reasonable or what is the standard? Should it be shen/script instead of shen-script?

tizoc commented 5 years ago

@rkoeninger sounds good to me. For Shen/Scheme I only added shen/scheme for now, will give it more thought in the future (I missed the symbol for the operating system, but will do that in the next release).

shen-script is fine btw, I use shen/scheme because thats the name of the port, not because the slash has any special meaning.

rkoeninger commented 5 years ago

I'm having trouble with the launch extension. In node, process.argv is returning:

[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\Users\\koeningerr\\Workspace\\Me\\ShenScript\\scripts\\repl.js' ]

which I convert to a cons list of course. Trying to run with no additional arguments prints:

ERROR: Invalid argument: C:\Users\koeningerr\Workspace\Me\ShenScript\scripts\repl.js
Try `C:\Program Files\nodejs\node.exe --help' for more information.

shen.exe can't run without any arguments now?

...ah, it's taking 'C:\\Users\\koeningerr\\Workspace\\Me\\ShenScript\\scripts\\repl.js' as the first flag and failing.

...eh, I'm just going to fix the args passed into shen.x.launcher.main as 'shen' and 'repl' for the repl.js script. There probably won't be a distributed repl program for this anyway.

tizoc commented 5 years ago

@rkoeninger the node.exe part has to be excluded, the first element in the list has to be the program that launches Shen itself.