rkokkelk / com.jreenen.homeyharmonyhub

Harmony hub support for Homey
GNU General Public License v2.0
8 stars 9 forks source link

Homey Pro SDK3 #108

Closed martijnchel closed 1 year ago

martijnchel commented 1 year ago

Since this is one of my favorite apps. Are you planning to support the new SDK for Homey Pro? Would be great of course. And if not, right now the probability is there that older apps will be removed, which would be a real shame.

Thanks!

pjmpessers commented 1 year ago

Great to see that you are supporting and working on SDKv3, @rkokkelk . I sideloaded it, but for me it seems to be crashing on my homey pro early 2019. Is this bug known by you?

In the mean time, thanks.

pjmpessers commented 1 year ago

Hello @rkokkelk . I sideloaded the master brach, and it works for me. But i don't see a change in the version number. It is still V2.0.9. Is this now HP2023 compatible?

Thanks for supporting and developing this app.

rkokkelk commented 1 year ago

No the changes on the master branch is some initial work to clean up the code. The active development will be done in the sdkv3 branch and is currently not stable. Once I'm ready to release an alpha version I'll let you guys know.

Wvanoors commented 1 year ago

Thanks a lot for updating the app! @rkokkelk.

rkokkelk commented 1 year ago

A test release has been published. Please feel free to test and provide feedback.

pjmpessers commented 1 year ago

Hello Roy.

I updated the test version. And this one doesn't crash. It seems that devices works. But when i want to use a activity it is saying "could not get device by id"

If i go to devices and then install harmony and choose activities then i see them all. So it seems he doen't look at the old device id for activities and want to make new ones.

But then many flows will be broken.

rkokkelk commented 1 year ago

Yeah this update should definitely not result in the requirement of adding the Hub again, thus destroying all existing flows. I've not encountered this is issue on my own installation, but will look into it.

pjmpessers commented 1 year ago

Thank you Roy. If i'm sure that all the faults are gone and it is HP2023 compatible i don't mind te rebuild my flows. But only if i'm sure the little faults and errors are gone. I'm already excited and hopeful that my harmony is still usable on HP2023 thanks to developers like you.

caseda commented 1 year ago

I've just installed v3 as well, on an older Homey Pro (2019) and Homey Pro (2023) but have also the "invalid device id" for activities, this is for both Homeys, where the older Homey has exisiting devices and activities, but the new Homey Pro is (of course) fully new devices.

rkokkelk commented 1 year ago

I've identified the issue and should not be fixed. It has been fixed by f1c0639. Please us the test link to reinstall the app with the latest version.

caseda commented 1 year ago

should not be fixed

I guess you meant: "should now be fixed" 😜

Confirmed working with v3.0.1 on both Homeys

Wvanoors commented 1 year ago

Bit off-topic maybe (sorry) but does somone her knows if Homey reproduces the ir-signals? And would it be possibel to use a bridge as repeater in a different room with he same one Harmony Hub? I am planning to get me a used hub soon.....

rkokkelk commented 1 year ago

@Wvanoors this issue is specific regarding the development of the SDKv3 support for the Logitech Harmony Hub app. For general questions regarding the app and what it can / can't do, please post them at the forum:

rkokkelk commented 1 year ago

With the official release of the latest version which set SDK version 3, I define this issue resolved.