search

rkokkelk / homey-wear

WearOS app for the Athom Homey
MIT License
0 stars 2 forks source link

Solution for https://github.com/rkokkelk/homey-wear/issues/1 #2

Closed RoadXY closed 4 years ago

RoadXY commented 4 years ago
RoadXY commented 4 years ago

Should commit to Develop Branch, not Master, sorry

rkokkelk commented 4 years ago

Hi thank you for the PR. But it is fine to make the PR for the master branch, develop is currently in a none stable situation and I would prefer to release this bugfix as soon as possible.

However in your PR you put 2 commits, the second one is not required for the bugfix and which changes a lot of variables, which can have an unspecified impact on the app and would require a lot more testing. Could you therefore please remove this commit from this PR, and maybe create a separate PR for those issues.

In your fix you specified just to skip all devices which do not contain the required capabilities. Although this is appropriated, I'm thinking this might result in confusion in the users to why certain favorite devices are not listed in the app. I prefer a solution which shows all devices but which show a pop-up indicating this device is not supported or a greyed out device.