search

rkoshak / openhab-rules-tools

Library functions, classes, and examples to reuse in the development of new Rules.
Other
62 stars 23 forks source link

Created a JavaScript utility to work with openHAB group members #62

Closed florian-h05 closed 2 years ago

florian-h05 commented 3 years ago

group_utils intoduces a library function with the following functions:

Get the names, labels or states of the direct or all members of a group. Perform the arithmetic operations known from the openHAB group item definition on the states or count how many members' states match a given expression.

I would be very pleased when my pull request would be approved.

rkoshak commented 3 years ago

Thanks for the submission. I've had writing a library like this in mind for some time. I have some requested changes. If you have any questions or counter arguments of other ideas please let me know.

florian-h05 commented 3 years ago

Thanks for the submission. I've had writing a library like this in mind for some time. I have some requested changes. If you have any questions or counter arguments of other ideas please let me know.

Thank you for your feedback, I will work on your requested changes.

Commit ff16adf: Done with the requested changes of the get(All)Members function group. Commit b61f9a3: Done with the requested changes of the count functions. Commit 73efde3: Done with the requested changes of the arithmetic operations.

To-Do:

rkoshak commented 3 years ago

It'll probably be a couple of days for me to review the new commits but a quick glance shows that everything looks good.

florian-h05 commented 2 years ago

What is the current state with merging the PR?

rkoshak commented 2 years ago

I need to gather together a couple of hours to look at it on a big screen before I hit merge. I've been burned by accepting PRs that I've only reviewed on my phone so I'm hesitant to just pull the trigger. I'm sure it's fine but life has been in the way.

I've not forgotten it. It will get merged.