some minor comment

[amywong-monster]

@rkoti-monster Sorry for my late reply. I didn't do anything over the weekend. It looks good and I learned a lot. Some comment

• In Server.runServer, change return type to ZIO[AppEnvironment, Throwable, ExitCode] and map bindHttp ExitCode to zio.ExitCode
• HelloServiceSpec, the check can be simplified as

   for {
     resOpt <- HelloService.service.run(Request[Task](Method.GET, uri"/")).value
     res <- ZIO.fromOption(resOpt)
     body <- res.as[String]
    } yield assert(body)(equalTo("hello!"))

• Similarly UserServiceSpec can be simplified as

    for {
      resOpt <- Users.routes.run(Request[UserTask](Method.GET, uri"/users")).value
      res <- ZIO.fromOption(resOpt)
      body <- res.as[List[User]]
    } yield assert(body)(isEmpty)

• Similarly for other test checking.

• About the service layer, given its functions are effectful, just wonder can it be a trait of something like

  trait Service {
  def get(id: Int): Task[User]
  
  def getAll: Task[List[User]]
  
  def create(user: User): Task[User]
  
  def delete(id: Int): Task[Boolean]
  
  def update(user: User): Task[Boolean]
  
  def getAccount(id: String): Task[Account]
  
  def getAllAccounts: Task[List[Account]]
  
  def createAccount(account: Account): Task[Account]
  
  def deleteAccount(id: String): Task[Boolean]
  
  def updateAccount(account: Account): Task[Boolean]
  }

  so that it can be mocked or whatever

[rkoti-monster]

Thanks @amywong-monster for the review.

Incorporated your first two comments.

The service layer is already in traits. The "accessors" are defined in a package object as suggested in https://zio.dev/docs/howto/howto_use_layers

trait UserService {
    def get(id: Long): Task[User]

    def getAll: Task[List[User]]

    def create(user: User): Task[User]

    def delete(id: Long): Task[Boolean]

    def update(user: User): Task[Boolean]
  }

  trait AccountService {
    def getAccount(id: String): Task[Account]

    def getAllAccounts: Task[List[Account]]

    def createAccount(account: Account): Task[Account]

    def deleteAccount(id: String): Task[Boolean]

    def updateAccount(account: Account): Task[Boolean]
  }