rkotze / git-mob

Co-author commits tool. A cross-platform command-line tool for social coding. Includes co-authors in commits when pair/mob programming.
https://www.npmjs.com/package/git-mob
MIT License
183 stars 21 forks source link

Distributed git-mob suggest-coauthors does not have proper line endings on osx #58

Closed DavidIAm closed 2 years ago

DavidIAm commented 4 years ago

Prerequisites

Description

the bin directory has suggest-coauthors file with windows line ending on the shebang line even though I installed it on a mac

Steps to Reproduce

  1. yarn global add git-mob
  2. git-mob suggest-coauthors

Expected behavior: [What you expect to happen] List of suggested coauthors

Actual behavior: [What actually happens] env: node\r: No such file or directory

Reproduces how often: [What percentage of the time does it reproduce?] 100% of the time... until I edit the file to remove the spurious cr

Versions

rkotze commented 4 years ago

@DavidIAm a quick look and yarn seem to install it with the windows line ending. However, using npm i -g git-mob does not and works as expected.

Will need to look into why yarn install does this.

rkotze commented 2 years ago

Looks like Yarn has stopped supporting the installation of global packages from version 2. I think this is no longer a relevant issue and will close.

I think it best to install using NPM.