search

rkoval / alfred-aws-console-services-workflow

A powerful workflow for quickly opening up AWS Console Services in your browser or searching for entities within them.
MIT License
312 stars 54 forks source link

Image and services refresh #7

Closed sliedig closed 5 years ago

sliedig commented 5 years ago

Added new image icons and services. Includes latest releases (except for a few that are in preview)

sliedig commented 5 years ago

Hello @rkoval, have you had a chance to review this pr?

rkoval commented 5 years ago

ahh sorry, i completely missed the notification for this. lemme have a look now

rkoval commented 5 years ago

@sliedig this all looks great. sorry for the delay here, but thanks for putting the time into all of this! see the comments i left.. either address or respond to them to give me reasoning for why the changes are.

sliedig commented 5 years ago

@sliedig this all looks great. sorry for the delay here, but thanks for putting the time into all of this! see the comments i left.. either address or respond to them to give me reasoning for why the changes are.

I'm on it. Didn't realise there were so many issues! Thanks for the review.

rkoval commented 5 years ago

@sliedig ended up using the generic blue AWS image as the default, as the newer one you added doesn't have square dimensions and looks weird/stretched when you open up the workflow (see https://github.com/rkoval/alfred-aws-console-services-workflow/commit/46c8b9584a14459ff11ba9ad654702d52ae74ac2). feel free to update though if you can get one with square dimensions

release: https://github.com/rkoval/alfred-aws-console-services-workflow/releases/tag/v2.0

EDIT: hotfix release here https://github.com/rkoval/alfred-aws-console-services-workflow/releases/tag/v2.1