Closed apolkosnik closed 5 years ago
I was under impression that I should have done the pull to the dev branch instead
On Mon, Oct 21, 2019, 09:47 Rok Krajnc notifications@github.com wrote:
Hi,
is something wrong with you pull request, or what is the reason for closing it?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/rkrajnc/minimig-mist/pull/89?email_source=notifications&email_token=AAH4UPTLBA36UP3DI2X7JWTQPWXH3A5CNFSM4JCIA5V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2MEDY#issuecomment-544522767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH4UPRXYQEDODXI2XUGNWDQPWXH3ANCNFSM4JCIA5VQ .
I've resubmitted the PR to the dev branch. No issues so far. I wasn't 100% sure if there would be any side effects on the get_bfoffset part, so I've narrowed down the impact to a known subset of opcodes to be on the safe side.
Hi,
is something wrong with you pull request, or what is the reason for closing it?