search

rkrug / plantuml

R package to build UML graphs using plantuml
https://rkrug.github.io/plantuml/index.html
GNU General Public License v3.0
76 stars 8 forks source link

set options .onLoad rather than .onAttach ? #22

Closed moodymudskipper closed 2 years ago

moodymudskipper commented 2 years ago

We get some errors when using plantuml without attaching because options are set only .onAttach and are required.

https://github.com/rkrug/plantuml/blob/master/R/aaa.R

It would be solved by setting options .onLoad, or by adapting the code that uses options to work when options are not set, .e.g. plantuml_update() calls dir.exists(getPlantumlOption("jar_path").

rkrug commented 2 years ago

Sounds linke a good Suggestion. Please feel free to submit a pull request. Would be fastest.

Thanks

Sent from my iPhone

On 1 Jan 2022, at 16:42, Antoine Fabri @.***> wrote:

 We get some errors when using plantuml without attaching because options are set only .onAttach and are required.

https://github.com/rkrug/plantuml/blob/master/R/aaa.R

It would be solved by setting options .onLoad, or by adapting the code that uses options to work when options are not set, .e.g. plantuml_update() calls dir.exists(getPlantumlOption("jar_path").

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

moodymudskipper commented 2 years ago

Thanks and done :).