search

rkrug / plantuml

R package to build UML graphs using plantuml
https://rkrug.github.io/plantuml/index.html
GNU General Public License v3.0
76 stars 8 forks source link

Image output type for EPS #24

Closed royratcliffe closed 2 years ago

royratcliffe commented 2 years ago

Output type of "text" injects the code of the EPS into the knit stream and becomes verbatim in the final PDF; pages of Adobe code. Seems more correct to apply include_graphics to the resulting EPS file.

rkrug commented 2 years ago

Thanks. As far as I can see, this looks fine - sound like a nice addition.

Unfortunately, the tests are broken, but if you confirm that these changes are working on your machine, I will merge them.

royratcliffe commented 2 years ago

Great package Rainer. Many thanks for plantuml.

I can confirm that it does work locally. I had a quick look at the CI test failures. It looks like the https://eddelbuettel.github.io/r-ci/ script has broken support for Pandoc; pity.

rkrug commented 2 years ago

Thanks a lot.