ActorSystem in `EitherJunctionSpec` is not terminated

rkrzewski / akka-cluster-etcd

Akka cluster management using etcd

Other

70 stars 14 forks source link

ActorSystem in `EitherJunctionSpec` is not terminated #32

Closed maciej closed 8 years ago

maciej commented 9 years ago

ActorSystem in EitherJunctionSpec is not terminated.

To be honest, I don't know whether ActorSystems resources are finalised after when it's GCed. A quick Google search did not provide an answer for this question. @rkrzewski do you know the answer? :-) Akka documentation recommends shutting down the system in tests in afterAll block.

Resource (think: threads) leakage is a problem when running tests interactively in SBT.

rkrzewski commented 8 years ago

EitherJunction and it's tests were removed in #7, but I found that EtcdClientSpec was not terminating it's ActorSystem. I've fixed that in ffe51563 and checked using jstack that there are no lingering dispatcher threads after running tests in sbt.