Overlays spanning dateline and r1108

[GoogleCodeExporter]

r1108 breaks PathOverlays crossing the Prime Meridian now.

Please revert PathOverlay back to last revision r1093.  Attached is also a fix 
for the original issue 363.  I believe this is the right approach now.

Additionally this fixes issues 345 and 285 which were still broken ... items 
east of dateline would still disappear when map center was west of dateline.

Thanks,

Will

Original issue reported on code.google.com by manim...@gmail.com on 19 Aug 2012 at 9:30

Attachments:

• MapView.java

[GoogleCodeExporter]

I've put back the previous revision but I don't have time for testing patches.

Original comment by neilboyd on 20 Aug 2012 at 6:13

• Changed state: Accepted

[GoogleCodeExporter]

Thanks Neil... understood.  I'll thoroughly test and report back. 

Original comment by manim...@gmail.com on 24 Aug 2012 at 5:29

[GoogleCodeExporter]

Thanks for the contribution manimaul - this has been a long-standing issue that 
I would love to see resolved. If you could post the changes as a patch-file so 
we can see exactly what you changed in MapView rather than posting the entire 
file then that would help. Also an explanation of how you fixed the issue would 
be useful. Thanks again!

Original comment by kurtzm...@gmail.com on 12 Sep 2012 at 8:25

[GoogleCodeExporter]

Thanks, I've attached the patch.

Explanation:

When getScrollX() is East of Prime Meridian (West of Dateline) and point is 
between dateline and 90W then pixels are a added to point.x to wrap around 
MapView

or

When getScrollX() is West of Prime Meridian (East of Dateline) and point is 
between dateline and 90E then pixels are a subtracted to point.x to wrap around 
MapView

Original comment by manim...@gmail.com on 13 Sep 2012 at 9:47

Attachments:

• MapView.patch

[GoogleCodeExporter]

To get this working perfectly on path overlays... some additional work needs to 
be done in PathOverlay with regard to the intersection clipBounds and 
mLineBounds which does not work properly when lines are drawn.

Original comment by manim...@gmail.com on 14 Sep 2012 at 12:05

[GoogleCodeExporter]

Ok I've put some work in to get this working fully with PathOverlays also.  
Attached are two patches that fixes this issue, issue 285, issue 345 and issue 
363. Two demonstration screenshots showing various overlays spanning dateline 
correctly.

Will

Original comment by manim...@gmail.com on 17 Sep 2012 at 8:29

Attachments:

• MapView.patch
• PathOverlay.patch
• dateline.png
• fiji_dateline.png

[GoogleCodeExporter]

Just to report back... I've had this patch in production now for about a month 
with 0 known issues.

Original comment by manim...@gmail.com on 27 Oct 2012 at 6:57