search

rksm / paredit.js

Generic reader and editor for s-expressions.
MIT License
107 stars 21 forks source link

Fix readNumber for decimals and negatives #22

Closed neil-lindquist closed 5 years ago

neil-lindquist commented 5 years ago

readNumber previously didn't support numbers with decimals in them or negatives. For example "(0.2)" was being read as [0, .2]. I expanded the test cases, but still couldn't get the tests running on my machine.

rksm commented 5 years ago

Thank you!

What's the problem with the tests? npm install + npm test should be all there is to it... do you get an error?

neil-lindquist commented 5 years ago

I don't think I got the test dependancies installed correctly, and when I was poking around the code, it looked like the test scripts are for sh. I gave up there since I develop on Windows. Admittedly, I don't really know much about using Node, just what I've needed to work on Atom-Slime/SLIMA. If another issue comes up, I'll see if I can run the tests on travis.

rksm commented 5 years ago

OK, usually you can just fix things via rm -rf node_modules followed by npm install. Then npm test should do what it's supposed to.