search

rksm / paredit.js

Generic reader and editor for s-expressions.
MIT License
107 stars 21 forks source link

Fix type declarations #27

Closed dandavison closed 2 years ago

dandavison commented 2 years ago

Hi, thanks very much for this excellent library cc @sgarciac.

I noticed these small errors in the type declaration files.

It's possible that all the falsey code paths should return null rather than undefined but since that would be a breaking change I'll open a separate PR for it, in case you want to do that.

(I'm using this library while contributing to this VSCode Emacs emulation extension).

rksm commented 2 years ago

Hi there! Thanks for these fixes! Yeah it might just be be a smallish change but given that at this points it's unclear if someone depends on those, I'll go with your other PR and do a minor version bump.