Windows RUNNER~1 paths

[rktjmp]

Windows has a max path length of 260 chars and will truncate long user names to 6~N names, so runneradmin becomes RUNNER~1.

We do not have any control over when these paths are given to us, and when we request stdpath("cache") it can return in this form depending on the system setup (username, etc).

This has a few issues:

• It seems that nvim_get_runtime_files cannot search dirs with RUNNER~1 in them.
• We might find lua files in "full path" form but when we construct our save paths, we concat with stdpath("cache"), meaning our paths cant match and we cant find the index file. Eg:
  • stdpath"cache" => C:/Users/RUNNER~1/temp
  • x.fnl gets saved at cache .. "/.../x.lua", eg C:/Users/RUNNNER~1/temp/.../x.lua
  • Later we might convince nvim to find the file at the full path, but we cant match it against a known product of hotpot, eg:
  • C:/Users/runneradmin/temp/.../x.lua != C:/Users/RUNNER~1/temp.../x.lua

RTP initially, with RUNNER~1,

pre-rtp-patch rtp-list C:/Users/RUNNER~1/AppData/Local/Temp/5_20230904160348/hotpot/compiled/*,D:\a\hotpot.nvim\hotpot.nvim,C:\Users\runneradmin\AppData\Local\5_20230904160348,C:\Users\runneradmin\AppData\Local\5_20230904160348-data\site,c:\tools\neovim\nvim-win64\share\nvim\runtime,c:\tools\neovim\nvim-win64\lib\nvim,C:\Users\runneradmin\AppData\Local\5_20230904160348-data\site\after,C:\Users\runneradmin\AppData\Local\5_20230904160348\after,C:/Users/RUNNER~1/AppData/Local/Temp/5_20230904160348/hotpot/compiled/vim-loader-cache-buster-1

nvim_get_runtime_file "" true

pre-rtp-patch nvim_get_runtime_file-empty { "D:\\a\\hotpot.nvim\\hotpot.nvim", "C:\\Users\\runneradmin\\AppData\\Local\\5_20230904160348", "c:\\tools\\neovim\\nvim-win64\\share\\nvim\\runtime", "c:\\tools\\neovim\\nvim-win64\\lib\\nvim" }

nvim_get_runtime_file "lua/abc.lua" true, no results

pre-rtp-patch nvim_get_runtime_file-abc.lua {}

Force replace RUNNER~1 with runneradmin,

post-rtp-patch rtp-list C:/Users/runneradmin/AppData/Local/Temp/5_20230904160348/hotpot/compiled/*,D:\a\hotpot.nvim\hotpot.nvim,C:\Users\runneradmin\AppData\Local\5_20230904160348,C:\Users\runneradmin\AppData\Local\5_20230904160348-data\site,c:\tools\neovim\nvim-win64\share\nvim\runtime,c:\tools\neovim\nvim-win64\lib\nvim,C:\Users\runneradmin\AppData\Local\5_20230904160348-data\site\after,C:\Users\runneradmin\AppData\Local\5_20230904160348\after,C:/Users/runneradmin/AppData/Local/Temp/5_20230904160348/hotpot/compiled/vim-loader-cache-buster-1

post-rtp-patch nvim_get_runtime_file-empty { "C:\\Users\\runneradmin\\AppData\\Local\\Temp\\5_20230904160348\\hotpot\\compiled\\5_20230904160348", "D:\\a\\hotpot.nvim\\hotpot.nvim", "C:\\Users\\runneradmin\\AppData\\Local\\5_20230904160348", "c:\\tools\\neovim\\nvim-win64\\share\\nvim\\runtime", "c:\\tools\\neovim\\nvim-win64\\lib\\nvim" }

File is found:

post-rtp-patch nvim_get_runtime_file-abc.lua { "C:\\Users\\runneradmin\\AppData\\Local\\Temp\\5_20230904160348\\hotpot\\compiled\\5_20230904160348\\lua\\abc.lua" }

[rktjmp]

https://github.com/neovim/neovim/issues/25019

[rktjmp]

Calling uv.fs_realpath will expand the path. We can either call this when we first generate the cache prefix, or (and?) call it everywhere. I am vaguely hesitant of calling it everywhere because it will convert symlink paths to their ... real paths, which might not be what we want for cache readability, or for files that get relinked a lot. We also must take care to call it first, then normalise everytime, else we end up with backslash paths.

Note also fs_realpath can return nil if the file does not exist, where as normalise will just "clean up" a path.