rktjmp / lush.nvim

Create Neovim themes with real-time feedback, export anywhere.
MIT License
1.4k stars 46 forks source link

Include more folders in rockspec build steps #129

Closed BuriedInTheGround closed 1 year ago

BuriedInTheGround commented 1 year ago

Description

This fixes the build via rockspec when installing the plugin through nixpkgs. Indeed, if the directories are not included, they will not be copied over the installation path.

Also fixed minor tab/space inconsistencies.

Before the patch

Installation path files

lush-nvim-before-path

Example vim command

lush-nvim-before

After applying the patch

Installation path files

lush-nvim-after-path

Example vim command

lush-nvim-after

rktjmp commented 1 year ago

Cheers. I actually don't use luarocks, does this require action upstream by @teto to pull the newer spec?

BuriedInTheGround commented 1 year ago

Yes, the source needs to be updated to use the new git revision.

Thanks for merging so fast though!

rktjmp commented 1 year ago

@teto knock knock I think this still needs refreshing on luarocks.org?

teto commented 1 year ago

@rktjmp There is now a github action that submits a new release to luarocks on new tags: https://github.com/nvim-neorocks/luarocks-tag-release . This way you could update luarocks yourself without much overhead and with your API key (or mine but better yours I think :) ) ? would that be ok if I submitted a PR ? here is a list of a few plugins that already adopted it https://github.com/nvim-neorocks/luarocks-tag-release/wiki/Example-configurations this basically adds a workflow like https://github.com/gennaro-tedesco/nvim-possession/blob/main/.github/workflows/release.yml

rktjmp commented 1 year ago

I see that luarocks has a "grab all modules associated with my github account" button, so I'm gunna run that so you'll probably get notification of ownership transfer. I'll add that workflow too.

rktjmp commented 1 year ago

Or, perhaps that button doesn't work... Can you transfer ownership to me https://luarocks.org/modules/soup

teto commented 1 year ago

I've removed my lush.nvim package from the "root" (i.e. default) manifest so you should be able to upload your own module

teto commented 1 year ago

also please dont forget to add the "neovim" label to it so it's easier to find via https://luarocks.org/labels/neovim