search

rktjmp / lush.nvim

Create Neovim themes with real-time feedback, export anywhere.
MIT License
1.49k stars 47 forks source link

External plugin templates #18

Open rktjmp opened 3 years ago

rktjmp commented 3 years ago

https://gist.github.com/kunzaatko/65c2317018afdbfc69abac9c7737722b

rktjmp commented 3 years ago

I do not think these files belong in the core lush project because:

1) They'll actually end up pretty hidden away for people who want to find them ("just cp .local/nvim/site/packer/compiled/lush.nvim/... ..." bleh)

2) They might end up with frequent changes or "upstream plugin changed" patches which will clutter lush's mainline git log.

I think they either go into:

I don't think I mind hosting a starter/helper repo, probably mostly just a matter of deciding on a format and writing a readme on what they are and how to use them.

@kunzaatko

kunzaatko commented 3 years ago

Maybe they could be added as a submodule to the https://github.com/rktjmp/lush-template.

rktjmp commented 3 years ago

Isn't that just including them directly but with extra steps?

At any rate. I think they should by default be:

So someone can grab the file and just update whatever parts they need without clearing any existing highlight links setup by the plugins.

How/where are you generating these from?

kunzaatko commented 3 years ago

Isn't that just including them directly but with extra steps?

I think that i order to download the submodules, you have to have write git submodule update to fetch them. That makes it opt-in rather then opt-out...

  • one rule per line
  • commented out

Sure, that is sensible.

How/where are you generating these from?

I just grabbed some big colourschemes, concatenated them, sorted them, filtered them and then edited the result with some vim macros. This inherently means, that the list of groups is not necessarily exhaustive...

I will make a private repo and invite you. Then, when it gets stable and we figure out the specific layout, we can make it public and figure out where to put it (or if I should transfer ownership to you or something)...

kunzaatko commented 3 years ago

You can look at the new repo I created. It should work with the new extends/with API hopefully. @rktjmp

rktjmp commented 3 years ago

Just thinking out loud,

the starter template could actually have multiple branches by default

You could probably start main then just merge in what you want git merge light_dark git merge plugins.

What I want to avoid is someone cloning down that repo, seeing 1000 files and thinking Lush is really heavy and complex when it really isn't.

kunzaatko commented 3 years ago

That seems reasonable. I think that it should also be emphasized in the README that the plugins are really templates and there is no need to implement a lot of them... So the template should then be in one repo not two as we agreed upon before...