search

rktjmp / lush.nvim

Create Neovim themes with real-time feedback, export anywhere.
MIT License
1.45k stars 47 forks source link

Update LSP highlight groups in template (and minor fix to spell hl-groups) #20

Closed savq closed 3 years ago

savq commented 3 years ago

The built-in LSP now has more highlight groups (and renamed some old ones).

I think those were added when LSP-diagnostics was moved to core, but I'm not sure. Anyways, these are the ones listed in the current docs (nightly).

There was also a small problem with the spell highlight groups. I made a separate commit for that.

rktjmp commented 3 years ago

Sounds super lazy, but could you update the neovim version mark too? I haven't updated nvim in a bit and don't want to do that right now incase something explodes.

https://github.com/rktjmp/lush.nvim/blob/86b3d4a83ba4254b99e88b8c239470f5a624c0fe/examples/lush-template/lua/lush_theme/lush_template.lua#L51

I can do it later of course, just if you're bored...

On a related topic - since we were talking about docs and stuff before, whats your brief opinion on removing the starter template in favour of a link to https://github.com/rktjmp/lush-template? Means only one place to update (big plus imo), and the other examples may go in a wiki or something.

I am split on keeping the repo "all you need" vs slim. I know previously I think I shot you down re: wiki etc.

rktjmp commented 3 years ago

OOB merge in 066c94014ef736641ea7bd29cda0a81cb53e7348

Gracias.

rktjmp commented 3 years ago

Oh you may have to force pull next time you sync, since I did some fiddling.

savq commented 3 years ago

whats your brief opinion on removing the starter template in favour of a link to https://github.com/rktjmp/lush-template?

I think the link would be better. The Lush API seems stable enough, and the template is more likely to change due to changes in LSP and tree-sitter (the default groups haven't changed since forever).

I am split on keeping the repo "all you need" vs slim

I think some separation is useful, since different docs serve different purposes. this documentation system explains it better than I could. Basically:

Btw, I recently found out you can clone github wikis as separate repos locally. I'm getting in the habit of putting my project-related notes there now.

Most templates are sort of how-tos, but since they're multi-file examples, having the in the repo also helps. I think the exception is the big example template. That one says "take this, you should know what to do." So that's another reason it could stay separate.