rkumar / rbcurse

ruby based curses widgets: fields, buttons, textarea. menus, message boxes, tabbed panes, tables, listboxes, splitpanes, scrollpanes. Event based, MVC architecture. (DEPRECATED - PLS USE rbcurse-core)
http://totalrecall.wordpress.com/
138 stars 13 forks source link

Ruby 1.8 fixes #9

Closed kalbasit closed 13 years ago

kalbasit commented 13 years ago

Using Ruby 1.8, I've got various exceptions, I've applied a couple of patches and now test2.rb runs smoothly on Ruby 1.8

kalbasit commented 13 years ago

By the way, why the project is not tested ? I mean using Rspec or TestUnit ? It seems very promising but automated tests makes sure we do not end up with these kind of errors.

rkumar commented 13 years ago

First of all, I need to know which version you are using. Alot has changed, especially in the color and attribute setting. If this is an old version, i can apply the patch to that.

As far as the 2 textview commits are concerned, i totally agree on both. I forgot about 1.8.

I have struggled to find a way of automating testing. I cannot tell you what a headache it is. However, since this is all executed inside ncurses, there is no way for me to test but the hard manual way. Most of the bugs usually are visual.

I have made extensive additions and cleanup in 1.4.1 which i am about to push.

After that i intend breaking this up into rbcurse-core and two or 3 others : extras and experimental so that i can ensure that core is always tested and backward compatible with minimal changes. This will also prevent bloat in the core widgets.

Currently, if i click "Merge Pull Request" i take it that will work only for Master. I am about to merge 1.4.1 into Master. I think i need to push them to the 1.4.0 branch also, and to my local copy. (my github knowhow is quite basic).

Thanks a lot.

kalbasit commented 13 years ago

I'm using version 1.4.0, the latest released version, although the patches are against the master branch.. If you think that patched might conflict with the 1.4.1 branch, then merge first and I'll update this branch as needed for Ruby 1.8

Thanks