search

rkusa / koa-passport

Passport middleware for Koa
MIT License
774 stars 54 forks source link

Update Example in the docs to use koa-session2 #99

Closed etherealite closed 7 years ago

etherealite commented 7 years ago

Would it be worth changing the example in the docs from koa-generic-session to koa-session2? I see no evidence that the author of koa-generic-session is planning on supporting Koa 2 in a timely manner.

rkusa commented 7 years ago

Sounds good. Are you maybe aware of the differences between koa-session and koa-session2?

etherealite commented 7 years ago

I'm afraid I'm not aware of any differences in interface or semantics. Once I have more experience with koa-session2 I'll report back

etherealite commented 7 years ago

Looks like koa-session2 is far fro API compatible from koa-generic-session. From the activity that I'm seeing in the issue tracker for koa-generic-session, someone has already made an API compatible port to Koa2 called koa-session-minimal. Waiting to see if the Koa org merges with this new project is probably the best thing to do at the moment.

rkusa commented 7 years ago

I have replaced koa-generic-session with koa-session for now (just decided on the fact that it lives int the koajs org) to get rid of koa-convert. Thanks for bringing this up!

https://github.com/rkusa/koa-passport-example/commit/7de29cf3c57f02e3db8ccea73bb5fcc3e8a09fd1

etherealite commented 7 years ago

It was my pleasure.

lukeramsden commented 7 years ago

@etherealite The docs don't appear to be up to date with that then

etherealite commented 7 years ago

@lukeramsden When you say

The docs don't appear to be up to date with that then

I'm not sure which docs you are referring to, nor what particular changes such documents would require.

Can you please clarify?

lukeramsden commented 7 years ago

@etherealite I'm referring to this

rkusa commented 7 years ago

@lukeramsden Good find, will be updated, thanks!