rkyleg / asdf-julia

MIT License
25 stars 16 forks source link

Fixed OSX copy to locate distribution root to install dir #11

Closed hickey closed 3 years ago

hickey commented 3 years ago

Found that the copy command on OSX was copying the Julia distribution out of the DMG and adding an extra directory level to the install directory. So instead of having the Julia binary located at bin/julia it would be located at julia/bin/julia and the asdf shim would not be installed. This was because the source directory was not terminated in a '/' and it would copy out of the DMG with the additional julia directory.

I also found by happenstance that there was a minor bug with the $volume_path variable where if the Julia DMG was left mounted because of an error, the second time the install script is executed $volume_path will have a value of /Volumes/Julia-1.4.2 2 (note the space) and then would fail to umount the DMG. asdf would then see the exit code of the install script and fail to create the shim file. So quoting $volume_path and the derived $source_path variables fixed this problem.

rkyleg commented 3 years ago

@hickey thanks!