search

rkzofficial / miraie-ac

MirAIe-AC API for Python
MIT License
7 stars 7 forks source link

Add Horizontal Swing and Converti Support #4

Closed deCodeIt closed 1 month ago

deCodeIt commented 1 month ago

Add support for horizontal swing as well as Converti.

Tested on Panasonic 1.5 Ton 4 Star Wi-Fi Inverter Smart Split AC (Copper Condenser, 7 in 1 Convertible with AI, 4 Way Swing, PM Filter, CS/CU-NU18YKY4W,2023 Model, White)

deCodeIt commented 1 month ago

Tagging for review @rkzofficial

rkzofficial commented 1 month ago

@deCodeIt

First of all, thank you very much for raising the pull request.

This package is being used internally by ha-mirae-ac (Home assistant module). I believe there is currently no way to implement this convertible mode in the home assistant UI. Please correct me if I am mistaken.

Do you have any idea if this is possible?

deCodeIt commented 1 month ago

@deCodeIt

First of all, thank you very much for raising the pull request.

This package is being used internally by ha-mirae-ac (Home assistant module). I believe there is currently no way to implement this convertible mode in the home assistant UI. Please correct me if I am mistaken.

Do you have any idea if this is possible?

Yes, for the Converti mode, I was planning on using the preset to add converti options over there along with existing ones. https://developers.home-assistant.io/docs/core/entity/climate/#presets

deCodeIt commented 1 month ago

@rkzofficial If this looks good to you, can you merge it so I can use it to enhance ha-mirae-ac. That's my ultimate goal to make this patch.

rkzofficial commented 1 month ago

@rkzofficial If this looks good to you, can you merge it so I can use it to enhance ha-mirae-ac. That's my ultimate goal to make this patch.

Sure, once I am back home I will do that.

deCodeIt commented 1 month ago

@rkzofficial Can you publish the main branch to npm so I can use it to enhance ha-miraie-ac repo