rl-institut / RAMP

Repository of the open-source RAMP model for generating multi-energy loads profiles
European Union Public License 1.2
3 stars 0 forks source link

[Bug] "Upper limit switch on" testing too strict or input file is invalid and removing refridgerator causes a TypeError #32

Open GregoryIreland opened 1 year ago

GregoryIreland commented 1 year ago

New "Upper limit switch on" testing might be too strict or the input files I'm using are invalid giving a custom ValueError message

This worked with previous versions of RAMP.

If I run the command: ramp -i "ramp\input_files\Households_South_South_Wealth_9.xlsx" -n 10

with the attached "Households_South_South_Wealth_9.xlsx" input file I get the following error:

ValueError: There is something fishy with upper limit in switch on...

image

FIRST INPUT FILE: Households_South_South_Wealth_9.xlsx

Removing refrigerator from the list of appliances gives a TypeError

Then also if I remove the refrigerator (thought to be problematic) I get a different issue.

If I run the command: ramp -i "ramp\input_files\Households_South_South_Wealth_9_nofridge.xlsx" -n 10

with the attached "Households_South_South_Wealth_9.xlsx" input file I get the following error:

`TypeError: ufunc 'isnan' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

Perhaps this is because without the refrigerator, many of the additional custom cycle parameters are left empty?

image

SECOND INPUT FILE: Households_South_South_Wealth_9_nofridge.xlsx

Bachibouzouk commented 1 year ago

The removal of the refrigerator is likely to be an almost empty line, this looks like a pandas parsing error