Uncaught TypeError on refresh

4lm commented 5 years ago

Hi @nesnoj,

I have a bug, which sometimes throws an error in the browser console after freshly (re)loading the app:

Concerning function:

https://github.com/rl-institut/WAM_APP_stemp_abw/blob/feature/layers-in-results/static/stemp_abw/js/scn_functions.js#L30

The error doesn't seem to have an effect, at least I don't see one :wink:

Any ideas?

4lm commented 5 years ago

I can't properly reproduce the bug. It sometimes occures after reload and sometimes not :thinking:

nesnoj commented 5 years ago

It seems as if updateScenarioControls() is fired before slider #sl_wind is loaded which does not make sense to me. If this error occurs, the wind slider is enabled on startup which should NOT happen.

I cannot reproduce this behavior.. if you stumble across this message again, please check whether it's enabled or not, thx!

4lm commented 5 years ago

@nesnoj, this one was really obscure:

I checked how often above described bug occurred after refresh - it was about every 5 refreshes.
It was always the same mistake, occurring in the same else-clause of an if-else-statement.
In the case of the bug occurring, the Ion.RangeSlider (IRS) element #sl_wind was matched by JQuery first, but then a service method of the IRS was adding the class ".irs-hidden-input" afterwards and because of this, the matched JQuery element couldn't be found anymore
I tried a lot, but the only solution which worked in the end (tested ~ 50 refreshes) was a simple setTimeout of 100 ms to give IRS service method some time to add the .irs-hidden-input class: https://github.com/rl-institut/WAM_APP_stemp_abw/commit/4eab9bbf074f9dd28c462e714206feefd9d7b421

The solution seems a little hacky, so I leave this issue open for you to decide if you're OK with this fix ...

nesnoj commented 5 years ago

To my mind it's ok for now, I moved this one to milestone finalization.

nesnoj commented 5 years ago

I have the same error when adding the scenario markers on the sliders: The marker on the single slider in variable areas panel is always omitted.

It works with the same delay (7f51a99) but it'd be better to check if the input has class .irs-hidden-input as with slower clients this solution may raise problems.

So if everything else is done, go ahead ;)

rl-institut / WAM_APP_stemp_abw

Uncaught TypeError on refresh #40