search

rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

[Testing] Adding sources with an availability schedule may be excess code #584

Open smartie2076 opened 3 years ago

smartie2076 commented 3 years ago

In function D1, based on whether or not parameter TIMESERIES_NORMALIZED is in the asset dictionary of an energyProduction asset, a different oemof-solph asset is added. See: here and here

Due to the changes in #498, this is not applicable for any energy production assets that do have an timeseries connected to it anymore.

I do not see how an energy source that is dispatchable currently can have an availability schedule and therefore can include TIMESERIES_NORMALIZED. This would only be the case for geothermal plants, that have a seasonal availability. This is not implemented yet (eventhough it might be a good idea).

Also, if TIMESERIES_NORMALIZED is not included because we are dealing with a dispatchable fuel sink that does not have a timeseries provided (not filename in asset_dict), the exception if TIMESERIES in dict_asset: should not take place anymore, as they were used to define sources for peak demand pricing previously, but those sources have been replaced by transformers. This code should be deleted in both function snippets.

_Originally posted by @smartie2076 in https://github.com/rl-institut/mvs_eland/pull/498#r497374442_

smartie2076 commented 3 years ago

This might be connected to #825 and #829.