rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

[Release] Minimal requirements for first release for partners #592

Closed smartie2076 closed 3 years ago

smartie2076 commented 4 years ago

For the first release that is promoted to the partners, we do not have to fullfill all requirements outlined in #532. Instead, we should aim to finish the most pressing requirements and include the most important features. Below, I will gather the checklists of the different categories:

General

Features

Testing

Readthedocs

Bugfixes

smartie2076 commented 4 years ago

TBD: Which other points should be added to the minimal requirements, compare #532

SabineHaas commented 4 years ago

We didn't add #451 to the list above, but I think we said, that I should do that for the release, as well.

smartie2076 commented 4 years ago

We didn't add #451 to the list above, but I think we said, that I should do that for the release, as well.

I think it is somewhat optional.

I was also wondering if I should address this:

When using two conversion objects to emulate a bidirectional conversion assets, their capacity should be interdependent. This is currently not the case (#24, #133 )

Otherwise, one has to follow some kind of weird practice to define a bi-direcitonal inverter, and the input/otput capacities would be different. Also, one would have to distribute the costs between both assets, which also does not make any sense from the optimization point of view. It is again something that is very difficult to explain to the end-user, when the results change because of a later fix.

SabineHaas commented 4 years ago

I would include it

smartie2076 commented 3 years ago

How about the fix costs that we are currently not using? Do we want to include that in our minimal release? Its about the project costs that are not changed by the investment. If we are not using it, we should remove the field before our first release, I would say.

Bachibouzouk commented 3 years ago

How about the fix costs that we are currently not using? Do we want to include that in our minimal release? Its about the project costs that are not changed by the investment. If we are not using it, we should remove the field before our first release, I would say.

I don't think we are using them, I agree to get rid of them (we need to do so also from RTD)

smartie2076 commented 3 years ago

I think I do not understand @Bachibouzouk and @SabineHaas - do you want to delete the fix costs because we do not use them or because you think that we do not need to use them?

SabineHaas commented 3 years ago

I think I do not understand @Bachibouzouk and @SabineHaas - do you want to delete the fix costs because we do not use them or because you think that we do not need to use them?

I would delete them because we do not use them. But maybe I haven't understood the purpose of using them, yet. Do you still see any purpose for using them @smartie2076 ?

smartie2076 commented 3 years ago

I think I do not understand @Bachibouzouk and @SabineHaas - do you want to delete the fix costs because we do not use them or because you think that we do not need to use them?

I would delete them because we do not use them. But maybe I haven't understood the purpose of using them, yet. Do you still see any purpose for using them @smartie2076 ?

Well, if an end user knows that for initiating this or that project different fix costs occur (may be internal costs), then comparing two scenarios with different fix costs becomes tedious if you can not define them in the MVS itself. You can not compare the LCOEs anymore, nor the annuities. Therefore my idea was to allow end-users to define the fix costs somewhere, eventhough they are not used for the simulation itself but for a manual scenario comparison later.

smartie2076 commented 3 years ago

I still like the feature, but think we could simplify: Not an own file for fixcosts.csv, but maybe wrapped in project_data. We then would also have to add this in the cost post-processing in E before the minimal release.

SabineHaas commented 3 years ago

If I look at it from a user perspective I would keep the two files separately. e.g. in pvcompare we use project_data.csv (location, country, scenario_id,...) but not fix_costs.csv (as far as I can say from my knowledge about the purpose fix_costs).

smartie2076 commented 3 years ago

@SabineHaas can you cross off number 10 of the checklist when you fix #779? @Bachibouzouk I know you will not manage to fix number 7 (parameters) until the beta release, but thats fine. Can you change the checkmark to :x: if this is not included in the beta release?

@ciaradunks @Bachibouzouk this issue can be closed when you do the beta release tomorrow! (The beta release is not MVS 1.0.0, but should be MVS 0.X.X).