rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

[Bug] Json input file tests/benchmark_test_inputs/rerun/mvs_config.json is not up to date #658

Open smartie2076 opened 3 years ago

smartie2076 commented 3 years ago

The json input file tests/benchmark_test_inputs/rerun/mvs_config.json is not up to date with dev:

"energyBusses": {
        "ESS Li-Ion bus": {
            "storage_01": "ESS Li-Ion",
            "storage_charge_controller_in": "Charge Contoller ESS Li-Ion (charge)",
            "storage_charge_controller_out": "Charge Contoller ESS Li-Ion (discharge)"
        },
        "Electricity (DSO) bus": {
            "DSO_consumption": "DSO_consumption source",
            "DSO_feedin": "DSO_feedin_sink",
            "transformer_station_in": "Transformer station (DSO) consumption",
            "transformer_station_out": "Transformer station (DSO) feedin"
        },
        "Electricity bus": {
            "Electricity excess": "Electricity excess_sink",
            "demand_01": "Harbor",
            "demand_02": "Remaining demand",
            "demand_03": "Shore power (docked ships)",
            "solar_inverter_01": "Solar inverter (mono)",
            "storage_charge_controller_in": "Charge Contoller ESS Li-Ion (charge)",
            "storage_charge_controller_out": "Charge Contoller ESS Li-Ion (discharge)",
            "transformer_station_in": "Transformer station (DSO) consumption",
            "transformer_station_out": "Transformer station (DSO) feedin"
        },
        "PV plant (mono) bus": {
            "pv_plant_01": "PV plant (mono)",
            "solar_inverter_01": "Solar inverter (mono)"
        }

This should be of form

"energyBusses": {
        "ESS Li-Ion bus": {
            "label": "ESS Li-Ion bus",
            "energyVector": "Electricity"
            "assetDict": {
                "storage_01": "ESS Li-Ion",
               "storage_charge_controller_in": "Charge Contoller ESS Li-Ion (charge)",
                "storage_charge_controller_out": "Charge Contoller ESS Li-Ion (discharge)"
                }
           },

This was recognized in #649. The mismatch should actually result in a failing benchmark test, so we need to investigate why this does not happen. @Bachibouzouk do you have an idea?

Checklist to make sure that the bug report ist complete:

smartie2076 commented 3 years ago

Of couse I can do a manual fix in #649, but there should still be a benchmark test that recognizes the mismatch nevertheless.

Bachibouzouk commented 3 years ago

This input folder is only used in tests/test_sensitivity.py and the latter does not run any tests, so it is not a priority to update this json file