Add benchmarktest for maximumCap constraint and adapt maximumCap usage

rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project

GNU General Public License v2.0

21 stars 10 forks source link

Add benchmarktest for maximumCap constraint and adapt maximumCap usage #830

Closed SabineHaas closed 3 years ago

SabineHaas commented 3 years ago

It would be good to add a benchmark test for maximum capacity constraint.

As described in #825, it would be better not to adapt maximumCap in C0.process_maximum_cap_constraint() but to change the maximum of components that use TIMESERIES_NORMALIZED in D1 functions instead.

Instead of adapting the inputs in D1 functions we also argumented that it would be even better to introduce new parameters, e.g. maximumCap_adaptedToPeak, or maxiumCap_adapted. @smartie2076 should this be done here already? --> This should also be implemented for `installedCap' then, in case it will be adapted to solve #825.

Connected to #829

SabineHaas commented 3 years ago

@ciaradunks this could be a good first component-related issue for you

SabineHaas commented 3 years ago

Maybe in the same benchmark test you could also check installedCap and input/output time series for a production asset as mentioned in #831 (And #825) - or would you prefer that in another place @smartie2076 ?

check for installedCap * time_series == time series in output

SabineHaas commented 3 years ago

discussion protocol :)

Maximum cap benchmark test:

Run a simulation with maximumCap constraint (of a production asset) and check whether OPTIMIZED_ADD_CAP <= maximumCap
I think a good start is to use Feedin_optimize inputs (benchmark_test_inputs) and adapt them to your needs.
The test can be added to test_benchmark_constraints.py

Time series

specified time series --> max(timeseries) < 1
normalized time series --> max(timeseries) = 1